Re: [PATCH] parport_pc to use pnpbios_register_driver()

Kai Germaschewski (kai@tp1.ruhr-uni-bochum.de)
Sun, 11 Nov 2001 21:42:34 +0100 (CET)

On Sat, 10 Nov 2001, Thomas Hood wrote:

> > Here's a patch to make parport_pc.c use pnpbios_register_driver()
> instead of pnpbios_find_device.
>
>
> [...]
>
> +#if defined (CONFIG_PNPBIOS) || defined (CONFIG_PNPBIOS_MODULE)

linux/isapnp.h has the following code:

---
#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
 
#define __ISAPNP__

---


I believe the pnpbios driver should do things something similar. Users of 
the interface should then only check for #ifdef __PNPBIOS__.


The reasoning behind this is the following: When you have a driver 
built-in, but pnpbios modular, the driver cannot use pnpbios 
functionality. The above definition reflects exactly this.


(BTW: The drivers using ISAPnP functionality seem to generally get this 
wrong, I'll look into cleaning this up. In drivers/scsi/aha152x.c it's 
done right)


--Kai






-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/