Re: CPQARRAY driver horribly broken in 2.4.14

[J Sloan]

This is a multi-part message in MIME format.
--------------0B4AB4FD009D357EEBF46038
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Linux Kernel Developer wrote:

> Hi all,
>
>      I'm using the cpqarray driver for a Compaq Smart Arrat 3100ES
> controller on a Compaq Proliant 7000.  Today I tried upgrading the kernel to
> 2.4.14.  Soon after the upgrade I though about making a small change in the
> kernel however as soon as I tried doing a "make dep" the system oopsed and
> froze.

Been there, done that, bought the t-shirt.

The attached patch courtesy of Jens Axboe
fixed my Compaq 6500 which was giving me
fits - basically in 2.4.14 it had a nasty habit of
scribbling on the disk and then locking up,
requiring a power cycle, manual fsck and
file restoration to get it running again.

With this patch 2.4.14 has been solid.

cu

jjs

--------------0B4AB4FD009D357EEBF46038
Content-Type: text/plain; charset=us-ascii;
 name="cciss-dequeue-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cciss-dequeue-1"

--- linux/drivers/block/cciss.c~	Thu Nov  8 11:36:24 2001
+++ linux/drivers/block/cciss.c	Thu Nov  8 11:37:03 2001
@@ -1307,6 +1307,8 @@
 	if (( c = cmd_alloc(h, 1)) == NULL)
 		goto startio;
 
+	blkdev_dequeue_request(creq);
+
 	spin_unlock_irq(&io_request_lock);
 
 	c->cmd_type = CMD_RWREQ;      
@@ -1386,12 +1388,6 @@
 
 	spin_lock_irq(&io_request_lock);
 
-	blkdev_dequeue_request(creq);
-
-        /*
-         * ehh, we can't really end the request here since it's not
-         * even started yet. for now it shouldn't hurt though
-         */
 	addQ(&(h->reqQ),c);
 	h->Qdepth++;
 	if(h->Qdepth > h->maxQsinceinit)

--------------0B4AB4FD009D357EEBF46038--