Re: [Lse-tech] [PATCH]Disk IO statisitics gathering for all disks

[Christoph Hellwig]

On Thu, Nov 08, 2001 at 02:33:44PM -0800, Mingming cao wrote:
> Hello,
> 
> Attached is a patch to dynamically allocate the data buffers for the
> disk statistics, and to extend the gathering of disk statistics to
> include major numbers greater than 15.
> 
> A disk statistics structure is allocated when a new block device 
> is registered.  A global array (kstat.dkdrive_info[]) is used
> to hold the address of the statistics structures for all block
> devices.  The  disk statistics lookup is the same as before: indexed by
> the major number and the disk number.

A very minor nitpick: please use struct dk_stat (or disk_stat) instead of
dk_stat_t - it is by no means an opaque type.

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.