Re: [PATCH] 802.1q-support for 3c59x.c

[Andreas Ferber]

On Wed, Nov 07, 2001 at 11:03:58AM -0500, Jeff Garzik wrote:
> > 
> > +/* The Ethernet Type used for 802.1q tagged frames */
> > +#define VLAN_ETHER_TYPE 0x8100
> This needs to be ETH_P_8021Q from if_ether.h.

OK. An updated patch will follow in a few days, as Alan requested not
sending new patches for some days.

> Have you tested this?

Sure. I'm actually using it in production, and other people also
reported that it works well without any problems.

> I should think you would need a dev->change_mtu
> also.

No. The whole point of the patch is that you /don't/ have to change
the MTU on the physical interface for VLAN support.

Though with the registers I figured from the specs it will be only a
matter of a few lines to add a dev->change_mtu to the driver. I can
add it to the patch if someone wants it.

Another question, how do you feel about the #ifdefs in the patch? As
said before, always enabling will not pose any performance penalties
to those not using VLAN tagging, so I could equally well just remove
them if noone objects.

Andreas
-- 
       Andreas Ferber - dev/consulting GmbH - Bielefeld, FRG
     ---------------------------------------------------------
         [phone] - [e-mail] - www.devcon.net