Re: [PATCH] 2.5 PROPOSAL: Replacement for current /proc of shit.

Theodore Tso (tytso@mit.edu)
Tue, 6 Nov 2001 10:46:44 -0500


On Tue, Nov 06, 2001 at 09:48:52AM +1100, Rusty Russell wrote:
>
> What concerns me most is the pain involved in writing a /proc or
> sysctl interface in the kernel today. Take kernel/module.c's
> get_ksyms_list as a typical example: 45 lines of code to perform a
> very trivial task. And this code is sitting in your kernel whether
> proc is enabled or not. Now, I'm a huge Al Viro fan, but his proposed
> improvements are in the wrong direction, IMHO.

I'm all for simplifying the internal kernel interfaces. What I'm not
at *all* convinced about is that it's worth it to make serious changes
to the layout of /proc, /proc/sys, etc. And the concept of being able
to very rapidly and easily get at system configuration variables
without needing to make sure that /proc is mounted is a very, very
good thing.

While sysctl isn't the most compact way of doing things, it *is*
simpler than doing things using a raw /proc interfaces. If you just
want sysctl to modify a single integer variable, it's basically just a
table entry and a call to register that table with sysctl. If you
want to do more sophisticated things, then yes, it gets more
complicated faster than it probably should.

But the bottom line is as far as I'm concerned is:

Baby. Bathwater. Let's not throw out the wrong thing....

- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/