Re: ext3-0.9.15 against linux-2.4.14

[Andrew Morton]

"Steven N. Hirsch" wrote:
> 
> On Tue, 6 Nov 2001, Andrew Morton wrote:
> 
> > Download details and documentation are at
> >
> >       http://www.uow.edu.au/~andrewm/linux/ext3/
> >
> > Changes since ext3-0.9.13 (which was against linux-2.4.13):
> >
> > - For a long time, the ext3 patch has used a semaphore in the core
> >   kernel to prevent concurrent pagein and truncate of the same
> >   file.  This was to prevent a race wherein the paging-in task
> >   would wake up after the truncate and would instantiate a page
> >   in the process's page tables which had attached buffers.  This
> >   leads to a BUG() if the swapout code tries to swap the page out.
> >
> >   This semaphore has been removed.  The swapout code has been altered
> >   to simply detect and ignore these pages.
> >
> >   This is an incredibly obscure and hard-to-hit situation.  The testcase
> >   which used to trigger it can no longer do so.  So if anyone sees the
> >   message "try_to_swap_out: page has buffers!", please shout out.
> 
> Andrew,
> 
> I have been getting thousands of these when the system was under heavy
> load, but didn't realize it was from the ext3 code!  I'm using Linus's
> 2.4.14-pre7 + ext3 patch from Neil Brown's site (the latter is identified
> as "ZeroNineFourteen".)  Would you like me to upgrade kernel and patch?
> 

Now that's interesting.  The printk is in there so I can ensure
that the codepath gets tested and is known to work.

Could you please send me details of the hardware setup, URL
for Neil's patch and a description of the workload?  Whatever
I need to make it happen locally.

If the message bothers you, please just remove the printk from 
vmscan.c.