Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c

[Chris Wright]

* David Dyck ([e-mail]) wrote:
> 
> 
> drivers/block/block.o: In function `lo_send':
> drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page'
> drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page'
> 
> 
> a grep from deactivate_page only shows up in  linux/drivers/block/loop.c

appears that deactivate_page was removed (see patch-2.4.14).  the patch
below Works For Me with limited testing (mount loop back, write,
unmount, remount, stuff i wrote is still there ;-).  YMMV.

cheers,
-chris

diff -X /home/chris/dontdiff -Naur linux-2.4.14/drivers/block/loop.c linux-2.4.14-loop/drivers/block/loop.c
--- linux-2.4.14/drivers/block/loop.c	Thu Oct 25 13:58:34 2001
+++ linux-2.4.14-loop/drivers/block/loop.c	Mon Nov  5 17:06:08 2001
@@ -207,7 +207,6 @@
 		index++;
 		pos += size;
 		UnlockPage(page);
-		deactivate_page(page);
 		page_cache_release(page);
 	}
 	return 0;
@@ -218,7 +217,6 @@
 	kunmap(page);
 unlock:
 	UnlockPage(page);
-	deactivate_page(page);
 	page_cache_release(page);
 fail:
 	return -1;