Re: Two suggestions (loop and owner's of linux tree)

Jens Axboe (axboe@suse.de)
Thu, 25 Oct 2001 11:27:52 +0200


On Wed, Oct 24 2001, Lukasz Trabinski wrote:
> Hello
>
> I would like to suggest to change max_loop from 8 to 16 or more if it
> possible.
>
> --- linux.org/drivers/block/loop.c Wed Oct 24 15:23:11 2001
> +++ linux/drivers/block/loop.c Wed Oct 24 15:24:52 2001
> @@ -75,7 +75,7 @@
>
> #define MAJOR_NR LOOP_MAJOR
>
> -static int max_loop = 8;
> +static int max_loop = 16;
> static struct loop_device *loop_dev;
> static int *loop_sizes;
> static int *loop_blksizes;

You just bumped loop memory usage by 24000 bytes on my system with
something that can be handled with a boot parameter. I'd rather see a
max_loop = 4 or something patch instead...

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/