Re: hfs cdrom broken in 2.4.13pre

Brad Boyer (flar@pants.nu)
Mon, 22 Oct 2001 19:11:39 -0700 (PDT)


Tom Rini wrote:
> No, really. What's changed to break HFS cdrom support?

Based on the messages and glancing over the hfs code, I would guess
that the CD-ROM block device driver used to fake accessing the drive
at any random block size. The hfs code depends on being able to use
a particular block size (512) and if the driver for the block device
doesn't support it, stuff breaks.

(super.c lines 394-416/491 byte 10778/12361 87%)

/* set the device driver to 512-byte blocks */
set_blocksize(dev, HFS_SECTOR_SIZE);

To be more flexible, the hfs code shouldn't force a hard coded block size.

Brad Boyer
flar@allandria.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/