Re: IEEE1284_PH_DIR_UNKNOWN undeclared in 2.4.12

[John Duthie]

On Mon, 15 Oct 2001, Anders Eriksson wrote:

I had the same thing
disabled ieee in the printer config , and it worked
had every lp option built in ...

the 2.4.12 patch conntains this
- ----------------->8
+++ linux/drivers/parport/ieee1284_ops.c        Wed Oct
10 23:19:30 2001
@@ -359,6 +359,10 @@
                DPRINTK (KERN_DEBUG "%s: ECP direction: reverse\n",
                         port->name);
                port->ieee1284.phase = IEEE1284_PH_REV_IDLE;
+       } else {
+               DPRINTK (KERN_DEBUG "%s: ECP direction: failed to
reverse\n",
+                        port->name);
+               port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
        }

        return retval;
@@ -386,7 +390,13 @@
                DPRINTK (KERN_DEBUG "%s: ECP direction: forward\n",
                         port->name);
                port->ieee1284.phase = IEEE1284_PH_FWD_IDLE;
+       } else {
+               DPRINTK (KERN_DEBUG
+                        "%s: ECP direction: failed to switch forward\n",
+                        port->name);
+               port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
        }
+
- -------------------------->8

Did Linus forget to add all of a patch again ?

my guess is in
include/linux/parport.h
this need a line added

/* IEEE1284 phases */
enum ieee1284_phase {
        IEEE1284_PH_FWD_DATA,
        IEEE1284_PH_FWD_IDLE,
        IEEE1284_PH_TERMINATE,
        IEEE1284_PH_NEGOTIATION,
        IEEE1284_PH_HBUSY_DNA,

-> Date: Mon, 15 Oct 2001 07:55:55 +0200
-> From: Anders Eriksson <[e-mail]>
-> To: [e-mail]
-> Subject: IEEE1284_PH_DIR_UNKNOWN undeclared in 2.4.12
->
->
-> Just downloaded 2.4.12, and the compile barfs as follows, any
-> suggestions? The thing is nowhere in the source.
->
-> /Anders
->
->
-> gcc -D__KERNEL__ -I/home/ander/tmp/linux-milou-12/include -Wall
-> -Wstrict-prototy
-> pes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing
-> -fno-common -pi
-> pe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS
-> -include /hom
-> e/ander/tmp/linux-milou-12/include/linux/modversions.h   -c -o
-> ieee1284_ops.o ie
-> ee1284_ops.c
-> ieee1284_ops.c: In function `ecp_forward_to_reverse':
-> ieee1284_ops.c:365: `IEEE1284_PH_DIR_UNKNOWN' undeclared (first use
-> in this func
-> tion)
-> ieee1284_ops.c:365: (Each undeclared identifier is reported only once
-> ieee1284_ops.c:365: for each function it appears in.)
-> ieee1284_ops.c: In function `ecp_reverse_to_forward':
-> ieee1284_ops.c:397: `IEEE1284_PH_DIR_UNKNOWN' undeclared (first use
-> in this func
-> tion)
-> make[2]: *** [ieee1284_ops.o] Error 1
-> make[2]: Leaving directory `/home/ander/tmp/linux-milou-12/drivers/par
-> port'
->
->
-> $ find . -type f | xargs grep IEEE1284_PH_DIR_UNKNOW
-> N
-> ./drivers/parport/ieee1284_ops.c:               port->ieee1284.phase
-> = IEEE1284_PH_DIR_UNK
-> NOWN;
-> ./drivers/parport/ieee1284_ops.c:               port->ieee1284.phase
-> = IEEE1284_PH_DIR_UNK
-> NOWN;
->
->
-> -
-> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
-> the body of a message to [e-mail]
-> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-> Please read the FAQ at  http://www.tux.org/lkml/
->

-- 
John Duthie
E-Mail:   <[e-mail]>
Phone:    [phone]
Cell:     [phone]
Web:      http://www.earthlight.co.nz/users/spudgun/
 When you choke a smurf, what color does it turn?
(Hi! I'm a .signature virus! Copy me into your ~/.signature, please!)