Re: [PATCH] EFI GUID Partition Tables

[Richard Gooch]

Martin Wilck writes:
> Richard,
> 
> > You've put the devfs_unregister_slave() inside an #ifdef. Yuk! It
> > shouldn't be conditional.
> 
> I did that because I didn't want to pollute your code. The function
> was only needed for the UUID patch.
> 
> > And I'm not really sure that I like this
> > function in the first place, but that's not something I want to get
> > into right now.
> 
> I did not see a possibility to cleanly remove a slave that was
> registered before. Did I oversee something? Do you thing that
> functionality is superfluous?

The whole slave mechanism is a hack, created because of the badly
structured genhd layer. It's a convenience for lazy programmers (like
me, when I was hacking the genhd layer:-). I'd prefer to see it used
very sparingly.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]