RE: eepro100.c bug on 10Mbit half duplex (kernels 2.4.5 / 2.4.10 / 2.4.11pre6 / 2.4.11 / 2.4.10ac11)

[Robbert Kouprie]

Alan,

Your fix seems to have eliminated the problem. I found this strange, as
the device ids still did not match mine. So I added a PRINTK line in the
test, and found that _with_ your fix it DOES NOT get triggered. The ac
kernel WITH the bug however DOES trigger the test. 

So, as I have tested both your and Linus' driver (in which the whole
"if" was missing), one has to conclude that both the bug in de ac driver
AND the whole missing line in Linus' kernel made the test succeed, where
is actually SHOULD NOT succeed. So actually my NIC is perfectly ok, but
not in combination with a workaround for a bug it doesn't have ;) This
was what broke things.

So, the 10Mbit half-duplex workaround breaks stuff on the devices that
do not suffer from the bug. This is dangerous... ;)

Anyway, I'm upgraded to 100Mbit now, and the bug is fixed, so I'm happy
:)
Thanx for your help.

Regards,
- Robbert

> -----Original Message-----
> From: Alan Cox [mailto:[e-mail]] 
> Sent: donderdag 11 oktober 2001 21:34
> To: Robbert Kouprie
> Cc: 'Alan Cox'; [e-mail]
> Subject: Re: eepro100.c bug on 10Mbit half duplex (kernels 
> 2.4.5 / 2.4.10 / 2.4.11pre6 / 2.4.11 / 2.4.10ac11)
> 
> 
> >        if ((pdev->device=0x2449) || ( (pdev->device > 0x1030) &&
>                       ^^^^^^^
> 
> Well thats a bug (just fixed)
> 
> > My device's id is: 	8086:1229 - Intel, 82557 [Ethernet Pro 100]
> > The present ids are: 	8086:1030 - 82559 InBusiness 10/100
> > 				8086:1031-1039 - are not listed in my db
> > 				8086:2449 - 82820 820 (Camino 2) Chipset
> > Ethernet
> > 
> > For one thing, in Linus' 2.4.12 the if condition at line 802 isn't
> > present at all, so that sure isn't gonna work.
> 
> Try enabling the test regardless and seeing if it helps on your box
> 
>