Re: Compile Filure on 2.4.10-ac10+preempt+smp

[Mike Fedyk]

On Wed, Oct 10, 2001 at 01:15:25AM -0400, Robert Love wrote:
> On Wed, 2001-10-10 at 00:46, Mike Fedyk wrote:
> > Fail    2.4.10-ac10+preempt+smp
> > Success 2.4.10-ac10+preempt+up-apic+up-ipapic
> > Success 2.4.10-ac10+preempt
> > Success 2.4.10-ac10
> > 
> > Robert, can you do a test compile for smp just in case?
> 
> Ahh, yes.  Thank you for spotting this.  include/asm-i386/spinlock.h has
> two separate defines for spin_unlock and we only renamed one of them.  I
> guess you hit the conditional that used the other define...
>
> The attached patch fixes it.
>

Thank you.  Will compile now...

> > Also, I couldn't find any links to old patches on your web site...
> > [...]
> 
> I only keep around patches to the last official kernel, plus the latest
> -pre and -ac I patched.  Since the patch itself is being updated, its a
> pain to backport to older kernels.
>

No, I'm not asking for backport, just links to one version back just in case
the latest patch has a bug much like this...

I'd rather run one (working) version back than have to go to UP just to get
preempt...  Needless to say, I chose to keep smp.

Mike