Re: [PATCH] EFI GUID Partition Tables

[Richard Gooch]

Matt Domsch writes:
> Prompted by Al Viro's work to move the partition table handling code
> from using block device access to using the page cache, I've pulled
> the EFI GUID Partition Table (GPT) code from the IA-64 port patch
> and updated it.  I would like to see it included in the Linus and
> -ac trees, as it barely needs the IA-64 tree, and even then, only
> asm-ia64/efi.h which is already merged.  David Mosberger is happy to
> have it dropped from the IA-64 port.  This code has been in use on
> IA-64 for quite a while now, so I feel confident that it works.
> I've also used it quite a bit on x86.  The devfs GUID support is by
> Martin Wilck.

You've put the devfs_unregister_slave() inside an #ifdef. Yuk! It
shouldn't be conditional. And I'm not really sure that I like this
function in the first place, but that's not something I want to get
into right now.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]