Re: [PATCH] ATA RAID breaks modular IDE compile

Keith Owens (kaos@ocs.com.au)
Tue, 09 Oct 2001 16:15:04 +1000

On Mon, 8 Oct 2001 23:59:39 -0600,
Richard Gooch <rgooch@ras.ucalgary.ca> wrote:
> Hi, all. In 2.4.11-pre6, the ATA RAID code breaks compiling IDE as a
>module: I get duplicate "init_module" symbols. I don't even have
>ATA RAID enabled!

Yeuch! Who defined ide-mod-objs in terms of $(export-objs) and why?
Fix against 2.4.11-pre6.

Index: 11-pre6.1/drivers/ide/Makefile
--- 11-pre6.1/drivers/ide/Makefile Tue, 09 Oct 2001 11:09:32 +1000 kaos (linux-2.4/E/b/44_Makefile 1.1.2.3.1.1 644)
+++ 11-pre6.1(w)/drivers/ide/Makefile Tue, 09 Oct 2001 16:13:01 +1000 kaos (linux-2.4/E/b/44_Makefile 1.1.2.3.1.1 644)
@@ -75,7 +75,7 @@ obj-$(CONFIG_BLK_DEV_ATARAID_HPT) += hpt

ide-obj-$(CONFIG_PROC_FS) += ide-proc.o

-ide-mod-objs := $(export-objs) $(ide-obj-y)
+ide-mod-objs := ide.o ide-features.o $(ide-obj-y)
ide-probe-mod-objs := ide-probe.o ide-geometry.o

include $(TOPDIR)/Rules.make

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/