Re: highmem deadlock fix [was Re: VM in 2.4.10(+tweaks) vs. 2.4.9 -ac14/15(+stuff)]

[Andrea Arcangeli]

On Thu, Sep 27, 2001 at 05:34:17PM -0500, [e-mail] wrote:
> 
> 
> > -----Original Message-----
> > From: Andrea Arcangeli [mailto:[e-mail]]
> > Sent: Thursday, September 27, 2001 5:13 PM
> > To: Macaulay, Robert
> > Cc: Rik van Riel; Craig Kulesa; [e-mail]; Bob
> > Matthews; Marcelo Tosatti; Linus Torvalds
> > Subject: highmem deadlock fix [was Re: VM in 2.4.10(+tweaks) vs.
> > 2.4.9-ac14/15(+stuff)]
> > 
> > @@ -2519,7 +2521,9 @@
> >  	int tryagain = 1;
> >  
> >  	do {
> > -		if (buffer_dirty(p) || buffer_locked(p)) {
> > +		if (unlikely(buffer_pending_IO(p)))
> > +			tryagain = 0;
> > +		else if (buffer_dirty(p) || buffer_locked(p)) {
> >  			if (test_and_set_bit(BH_Wait_IO, &p->b_state)) {
> >  				if (buffer_dirty(p)) {
> >  					ll_rw_block(WRITE, 1, &p);
> > 
> 
> Im getting an undefined reference to the unlikely function in this patch.

ok, try adding #include <linux/compiler.h> to include/linux/kernel.h, I
prefer to have likely/unlikely always available.

Andrea