Re: Linux-2.4.10 - necessary patches

Oliver Xymoron (oxymoron@waste.org)
Mon, 24 Sep 2001 09:42:34 -0500 (CDT)


On Mon, 24 Sep 2001, Alan Cox wrote:

> > --- linux-2.4.10-pre7/include/scsi/scsi.h Fri Apr 27 13:59:19 2001
> > +++ linux/include/scsi/scsi.h Mon Sep 10 03:53:58 2001
> > @@ -214,6 +214,12 @@
> > /* Used to get the PCI location of a device */
> > #define SCSI_IOCTL_GET_PCI 0x5387
> >
> > +/* Used to invoke Target Defice Reset for Fibre Channel */
> > +#define SCSI_IOCTL_FC_TDR 0x5388
> > +
> > +/* Used to get Fibre Channel WWN and port_id from device */
> > +#define SCSI_IOCTL_FC_TARGET_ADDRESS 0x5389
> > +
>
> These are compaq made up ioctls. They shouldnt be merged like that. Instead
> there needs to be proper discussion about what is actualyl needed

And please, not ioctl(). iSCSI (SCSI-over-IP) is going to require similar
per-device information (this info isn't FC-specific), but probably a lot
more. Adding a dozen ioctls is bad. At least one of the current iSCSI
drivers puts this info in /proc/scsi/iscsi.

--
 "Love the dolphins," she advised him. "Write by W.A.S.T.E.."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/