Re: do we need 10 copies?

Kai Henningsen (kaih@khms.westfalen.de)
24 Sep 2001 01:39:00 +0200


kai@tp1.ruhr-uni-bochum.de (Kai Germaschewski) wrote on 23.09.01 in <Pine.LNX.4.33.0109232106020.14414-100000@vaio>:

> On Sun, 23 Sep 2001, Garst R. Reese wrote:
>
> > This table (512 bytes) and the code to implement crc-ccit is replicated
> > in 10 drivers. ppp-async even exports it. Surely there is a better way.
>
> As for the ISDN code (4 copies), there is the plan to use a a common HDLC
> en/decoding module, however that's a 2.5 thing. I'll take a look if I can
> find a generic solution then, but it might turn out difficult - having a
> module of its own just for that table wastes nearly a page, so that's
> probably worse than the current state of affairs.

Why a module? Just make it something the base kernel exports, like other
general library functions.

Oh, and ISTR that there are also still a number of zlib copies ... and,
uh, about the PPP code ...

MfG Kai
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/