Re: flush_tlb_all in vmalloc_area_pages

[Andrea Arcangeli]

On Fri, Sep 21, 2001 at 12:38:45AM +0200, Andrea Arcangeli wrote:
> On Thu, Sep 20, 2001 at 03:29:19PM -0700, David S. Miller wrote:
> > Please, I would heavily suggest leaving this area until 2.5.x there
> 
> ok

Linus please apply to next pre patch, I understood from David that for
him the direct mapping can overlap the vmalloc virtual address space, it
really doesn't make much sense to me but since this is a noop for me and
I trust him, we can really delay this to 2.5:

--- 2.4.10pre12aa2/mm/vmalloc.c.~1~	Thu Sep 20 01:44:20 2001
+++ 2.4.10pre12aa2/mm/vmalloc.c	Fri Sep 21 00:40:48 2001
@@ -144,6 +144,7 @@
 	int ret;
 
 	dir = pgd_offset_k(address);
+	flush_cache_all();
 	spin_lock(&init_mm.page_table_lock);
 	do {
 		pmd_t *pmd;

And btw, now I suspect David can have also have an arguments for the
tlb_flush removal (infact the problem is the same, if the address space
is shared by direct mapping and vmalloc we'd also need to flush the
tlb), but such one isn't really a noop for the other archs so I will be
more concerned not to reintroduce it and to at least just put an #ifndef
__i386__ around it (safe for both parts).

Andrea