Re: [PATCH] for drivers/char/sysrq.c

[Alan Cox]

> How did something this basic get submitted in the first place?!?
> Doesn't anyone bother compiling patches before sending to Linus?
> This is the second time today I've had to patch the kernel just to get
> the rotten thing to compile. I'm not happy that whoever put in those
> __builtin_expect()'s didn't bother testing with THE RECOMMENDED
> COMPILER!!! It's not the first time that sort of thing has happened.
> </whinge>

It got broken because the stable kernel API isnt. When I submitted it to
Linus I missed one specific random api of the week variance. Its been in
the -ac tree and vendor distros for a while, so it was tested.

Alan