Re: nfs client oops, all 2.4 kernels

[Olivier Molteni]

Stephan von Krawczynski wrote:

> On Mon, 10 Sep 2001 10:02:02 -0500 Erik DeBill <[e-mail]>
> wrote:
>
> > I've been running into a repeatable oops in the NFS client code,
> > apparently related to file locking.
>

>
> in linux/fs/locks.c I would say it fails either because thisfl_p is NULL or
> *thisfl_p is NULL. Try securing it via:
>
> static void locks_delete_lock(struct file_lock **thisfl_p, unsigned int wait)
> {
>         struct file_lock *fl;
>
>         if (thisfl_p == NULL || *thisfl_p == NULL)
>                 return;
>
>         fl = *thisfl_p;
>
>         *thisfl_p = fl->fl_next;
>         fl->fl_next = NULL;
>
> ...
> }
>
> This is for sure not the cure, but may help your setup.

Hi, see my post and related answers [ Oops NFS Locking in 2.4.x] I have the same
Problem.
Returning on *thisfl_p == NULL don't fix the trouble... Kernel no more Oops, but
process stay in wait state on IO (D).

See the answers from Trond Myklebust, I think he is right...

Regards,
Olivier.