Re: Linux 2.4.10-pre6

Stephen Frost (sfrost@snowman.net)
Sun, 9 Sep 2001 19:43:13 -0400


--cupjvedY0UaoiHsO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Linus Torvalds (torvalds@transmeta.com) wrote:
>=20
> Most noticeable (except perhaps for the NTFS update if you're a NTFS user)
> is that the broken bootdata patch that could cause some spurious MM
> corruption due to a double page free of the bootdata got reverted. This is
> the one that caused BUG reports from mm/page_alloc.c..

The changes to rd.c cause it to fail in compiling. Following
is a patch which I believe to be correct. It fixes the
compilation problem and the module appears to load, work and
unload correctly.

Stephen

--- linux-2.4.10-pre6-orig/drivers/block/rd.c Sun Sep 9 16:19:07 2001
+++ linux/drivers/block/rd.c Sun Sep 9 16:06:59 2001
@@ -259,7 +259,7 @@
/* special: we want to release the ramdisk memory,
it's not like with the other blockdevices where
this ioctl only flushes away the buffer cache. */
- if ((atomic_read(rd_bdev[minor]->bd_openers) > 2))
+ if ((atomic_read(&rd_bdev[minor]->bd_openers) > 2))
return -EBUSY;
destroy_buffers(inode->i_rdev);
rd_blocksizes[minor] =3D 0;
@@ -372,7 +372,7 @@
struct block_device *bdev =3D rd_bdev[i];
rd_bdev[i] =3D NULL;
if (bdev) {
- blkdev_put(bdev);
+ blkdev_put(bdev, BDEV_FILE);
bdput(bdev);
}
destroy_buffers(MKDEV(MAJOR_NR, i));

--cupjvedY0UaoiHsO
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7m/6QrzgMPqB3kigRAlXWAKCCOnGhJitx2bLRAZG8PiV9TTxwXACfV0nD
6cYtQoP3atW46Hn+/TXtJ1M=
=Ijq6
-----END PGP SIGNATURE-----

--cupjvedY0UaoiHsO--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/