Re: [PATCH] cpuid/msr + devfs

[Richard Gooch]

Zach Brown writes:
> > Better to have a central place which creates per-CPU directories,
> > which you can call into and grab a directory for a CPU.
> 
> I talked with arjan and rmk about this when playing around with per cpu
> statistics stuff.  Is the proc_cpu.c stuff in the patch useful?
> 
> 	http://www.osdlab.org/sw_resources/cpustat/cpustat-2.4.7.pre5-1.diff

Well, it can be used as a guide for where things have to be patched.
It's not really suited to creating devfs directories which can be used
by random CPU drivers, since you're using an initcall.

However, the per-CPU structures you seem to be creating appears to be
a logical place to add a devfs entry. As part of the CPU detection
process, that entry should be initialised. Then drivers can simply
reference that entry.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]