Re: [PATCH] cleanup in fs/super.c (do_kern_mount())

Andries.Brouwer@cwi.nl
Mon, 3 Sep 2001 13:53:07 GMT


From: Alexander Viro <viro@math.psu.edu>

New helper function: do_kern_mount() (aka. kern_mount() donw right).

+#define MS_NOUSER (1<<31)

But you introduce a new, undocumented, mount flag?

(It seems a pity to take away from the scarce resource
"bits in the mount flag" for kernel-internal purposes.
Today 14 bits (of the 16) are in use, and as soon as we'll need
the 17th, mount will stop adding this 0xC0ED0000 flag, and
we'll have 15 or 16 additional bits.

On the other hand, if you think this bit is also useful from
user space, then the use should be documented.)

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/