"David S. Miller" wrote:
> Right, and our equivalent is "NR_OPEN".
>
> Ok, I think I see what you and Tim are trying to say.
> I'm thinking in a select() minded way which is why I didn't
> understand :-)
Whew! :)
> Yeah, the check can be removed, but anyone who cares about
> performance won't pass in huge arrays of -1 entries if only
> the low few pollfd entries are actually useful.
of course...patch attached, for anyone who cares - do we need to send it to
anyone else, or are you going to channel it in, Dave?
-- Tim Hockin Systems Software Engineer Sun Microsystems, Cobalt Server Appliances thockin@sun.com --------------961B3A286156E310CA2558A4 Content-Type: text/plain; charset=us-ascii; name="poll-paranoid.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="poll-paranoid.diff"Index: fs/select.c =================================================================== RCS file: /home/cvs/linux-2.4/fs/select.c,v retrieving revision 1.5 diff -u -r1.5 select.c --- fs/select.c 2001/07/09 23:10:25 1.5 +++ fs/select.c 2001/08/15 00:28:13 @@ -419,9 +419,6 @@ if (nfds > NR_OPEN) return -EINVAL; - if (nfds > current->files->max_fds) - nfds = current->files->max_fds; - if (timeout) { /* Careful about overflow in the intermediate values */ if ((unsigned long) timeout < MAX_SCHEDULE_TIMEOUT / HZ)
--------------961B3A286156E310CA2558A4--
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/