Re: [PATCH] LVM snapshot support for reiserfs and others

[Andreas Dilger]

Chris writes:
> +static inline void write_super_lockfs(struct super_block *sb)
> +{
> +	lock_super(sb);
> +	if (sb->s_root) {
> +		if (sb->s_dirt && sb->s_op && sb->s_op->write_super)
> +			sb->s_op->write_super(sb);
> +		if (sb->s_op && sb->s_op->write_super_lockfs)
> +			sb->s_op->write_super_lockfs(sb);
> +	}
> +	unlock_super(sb);
> +}

Minor nit, could it be:
	if (sb->s_root && sb->s_op) {
		if (sb->s_dirt && sb->s_op->write_super)
			sb->s_op->write_super(sb);
		if (sb->s_op->write_super_lockfs)
			sb->s_op->write_super_lockfs(sb);
	}

I'm just going to do some testing...

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert