Re: [RFC][PATCH] Scalable Scheduling

[Hubertus Franke]

I thought, Linus's suggestion is pretty straight forward and clear, like
you do it.
We fix it and resubmit ASAP.

Hubertus Franke
Enterprise Linux Group (Mgr),  Linux Technology Center (Member Scalability)
, OS-PIC (Chair)
email: [e-mail]
(w) 914-945-2003    (fax) 914-945-4425   TL: 862-2003

Daniel Phillips <[e-mail]>@vger.kernel.org on 08/08/2001
03:06:01 PM

Sent by:  [e-mail]

To:   Mike Kravetz <[e-mail]>, Linus Torvalds
      <[e-mail]>
cc:   Hubertus Franke/Watson/IBM@IBMUS, [e-mail]
Subject:  Re: [RFC][PATCH] Scalable Scheduling

On Wednesday 08 August 2001 20:28, Mike Kravetz wrote:
> Yes we have, we'll provide those numbers with the updated patch.
> One challenge will be maintaining the same level of performance
> for UP as in the current code.  The current code has #ifdefs to
> separate some of the UP/SMP code paths and we will try to eliminate
> these.

Does it help if I clarify what Linus was suggesting?  Instead of:

         #ifdef CONFIG_SMP
                 .. use nr_running() ..
         #else
                 .. use nr_running ..
         #endif

write:

     inline int nr_running(void)
     {
     #ifdef CONFIG_SMP
          int i = 0, tot=nt_running(REALTIME_RQ);
          while (i < smp_num_cpus) {
               tot += nt_running(cpu_logical_map(i++));
          }
          return(tot);
     #else
          return nr_running;
     #endif
     }

Then see if you can make the #ifdef's go away from that too.  (If that's
too hard, well, at least the #ifdef's are now reduced.)

--
Daniel