Re: [RFC][PATCH] parser for mount options

Andreas Dilger (adilger@turbolinux.com)
Tue, 7 Aug 2001 16:02:44 -0600 (MDT)


Andreis writes:
> I did the same for 1.3.61 long ago. A fragment:
> with call for each filesystem
>
> parse_mount_options((char *) data, SIZE(opts), opts);
>
> I am not sure which of the two versions I prefer.
> For example, the above setup shows very clearly what the defaults are.

What else is nice about this variant is that you don't need to change
the prototype for parse_options() each time you add a new parameter,
you only pass the "opts" struct around.

Cheers, Andreas

-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/