Re: oops with 2.4.8-pre5

[Jens Axboe]

--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 07 2001, Jens Axboe wrote:
> On Tue, Aug 07 2001, Jens Axboe wrote:
> > On Tue, Aug 07 2001, Alex Romosan wrote:
> > > i got the following oops with kernel 2.4.8-pre5. i was just logged in
> > > remotely, reading email with gnus and maybe i had just run dselect
> > > (debian package installer):
> > 
> > This should fix it.
> 
> Eh scratch that braino, here's a right one...

Too tired, or something... I think I'll stop for today.

-- 
Jens Axboe

--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline; filename=sync_old_buffers-3

--- /opt/kernel/linux-2.4.8-pre5/fs/buffer.c	Tue Aug  7 10:28:50 2001
+++ fs/buffer.c	Tue Aug  7 22:32:36 2001
@@ -2581,10 +2472,15 @@
 
 			spin_lock(&lru_list_lock);
 			bh = lru_list[BUF_DIRTY];
+			if (!bh) {
+				spin_unlock(&lru_list_lock);
+				goto quit;
+			}
 			if (!time_before(jiffies, bh->b_flushtime))
 				continue;
 			spin_unlock(&lru_list_lock);
 		}
+quit:
 		run_task_queue(&tq_disk);
 		return 0;
 	}

--H8ygTp4AXg6deix2--