Re: oops with 2.4.8-pre5

[Jens Axboe]

--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 07 2001, Alex Romosan wrote:
> i got the following oops with kernel 2.4.8-pre5. i was just logged in
> remotely, reading email with gnus and maybe i had just run dselect
> (debian package installer):

This should fix it.

-- 
Jens Axboe

--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=sync_old_buffers-1

--- /opt/kernel/linux-2.4.8-pre5/fs/buffer.c	Tue Aug  7 10:28:50 2001
+++ fs/buffer.c	Tue Aug  7 22:17:51 2001
@@ -2581,13 +2472,17 @@
 
 			spin_lock(&lru_list_lock);
 			bh = lru_list[BUF_DIRTY];
+			if (!bh)
+				break;
 			if (!time_before(jiffies, bh->b_flushtime))
 				continue;
 			spin_unlock(&lru_list_lock);
 		}
 		run_task_queue(&tq_disk);
-		return 0;
+		break;
 	}
+
+	return 0;
 }
 
 int block_sync_page(struct page *page)

--6c2NcOVqGQ03X4Wi--