Re: [PATCH] one of $BIGNUM devfs races

[Richard Gooch]

Alexander Viro writes:
> Why on the Earth do you need it, in the first place? Just put the
> pointer to entry into inode->u.generic_ip and be done with that -
> it kills all that mess for good. AFAICS the only places where you
> really use that table is your get_devfs_entry_from_vfs_inode()
> and devfs_write_inode(). In both cases pointer would be obviously more
> convenient.

Damn. I've just run into a snag. My read_inode() needs to dereference
inode->u.generic_ip, however, I can only initialise this *after* the
call to iget() finishes. Now, I could shoehorn my pointer into
inode->ino (thanks to it being an unsigned long), but that's pretty
gross.

I also notice iget4() and the read_inode2() method, however, from the
comments, it looks like those are reiserfs-specific, and will die
soon. At the very least, it seems use thereof is discouraged.

Suggestions?

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]