Re: Linux 2.4.7-ac8

Keith Owens (kaos@ocs.com.au)
Tue, 07 Aug 2001 15:17:49 +1000


On Mon, 6 Aug 2001 19:03:21 +0100,
Alan Cox <laughing@shared-source.org> wrote:
>2.4.7-ac8

<rant>
The aic7xxx maintainer keeps trying to break the kernel build system,
introducing special cases just to support his broken makefiles. At the
same time he refuses to listen to suggestions for doing it correctly.
This is unacceptable, and will not work in kbuild 2.5. The module
install structure is an exact match for the kernel source structure,
with no need to install modules elsewhere. modutils >= 2.3.12 takes
care of the correct hierarchy, mkinitrd has no problem with the correct
tree.
</rant>

Index: 7.41/Rules.make
--- 7.41/Rules.make Tue, 07 Aug 2001 10:44:16 +1000 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.3 644)
+++ 7.41(w)/Rules.make Tue, 07 Aug 2001 15:10:31 +1000 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.3 644)
@@ -150,7 +150,7 @@ endif
#
ALL_MOBJS = $(filter-out $(obj-y), $(obj-m))
ifneq "$(strip $(ALL_MOBJS))" ""
-MOD_DESTDIR ?= $(shell $(CONFIG_SHELL) $(TOPDIR)/scripts/pathdown.sh)
+MOD_DESTDIR := $(shell $(CONFIG_SHELL) $(TOPDIR)/scripts/pathdown.sh)
endif

unexport MOD_DIRS
Index: 7.41/drivers/scsi/aic7xxx/Makefile
--- 7.41/drivers/scsi/aic7xxx/Makefile Tue, 07 Aug 2001 10:44:16 +1000 kaos (linux-2.4/y/d/24_Makefile 1.1.1.1.1.1 644)
+++ 7.41(w)/drivers/scsi/aic7xxx/Makefile Tue, 07 Aug 2001 15:10:40 +1000 kaos (linux-2.4/y/d/24_Makefile 1.1.1.1.1.1 644)
@@ -27,7 +27,6 @@ AIC7XXX_OBJS += aic7xxx_pci.o
endif

# Override our module desitnation
-MOD_DESTDIR = $(shell cd .. && $(CONFIG_SHELL) $(TOPDIR)/scripts/pathdown.sh)
MOD_TARGET = aic7xxx.o

include $(TOPDIR)/Rules.make

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/