Re: drivers/net/sk98lin/skproc.c undefined root_dev

[David S. Miller]

Keith Owens writes:
 > drivers/net/sk98lin/skproc.c:extern struct net_device *root_dev
 > Defined extern, all other definitions of root_dev are static, except in
 > sparc.  CONFIG_SK98LIN is not limited to sparc.  Either the config is
 > wrong or the code in skproc is wrong.

I think two things are wrong here, nice spotting:

1) root_dev in the sk98lin driver needs another name if it is
   going to be exported to multiple objects within the driver.
   Something like sk98lin_root_dev.

2) It should be non-static in skge.c

I distinctly remember it compiling and working correctly on x86
sometime earlier in the 2.4.x series, so perhaps this brokenness
is recent.

Later,
David S. Miller
[e-mail]