Re: drivers/ieee1394 duplicate symbol, 2.4.8-pre4

[Ben Collins]

On Mon, Aug 06, 2001 at 01:46:40PM +1000, Keith Owens wrote:
> drivers/ieee1394/raw1394.c:spinlock_t host_info_lock = SPIN_LOCK_UNLOCKED;
> drivers/ieee1394/nodemgr.c:spinlock_t host_info_lock = SPIN_LOCK_UNLOCKED;
> 
> when both raw1394 and nodemgr are linked into vmlinux, it gets
> 
> drivers/ieee1394/raw1394.o(.data+0x8): multiple definition of `host_info_lock'
> drivers/ieee1394/ieee1394.o(.data+0x8c): first defined here
> 
> Either host_info_lock should be static or it should be defined as
> extern in one source and referenced in the others.

It should be static. Thanks for the report. I believe this is fixed in
CVS, and if not, it will be soon.

Hopefully we'll get a chance to sync CVS to Linus before 2.4.8 final. If
not, I'll submit a patch for that bug atleast.

-- 
 .----------=======-=-======-=========-----------=====------------=-=-----.
/  Ben Collins  --  ...on that fantastic voyage...  --  Debian GNU/Linux   \
`  [e-mail]  --  [e-mail]  --  [e-mail]  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'