Re: [PATCH] vxfs fix

Christoph Hellwig (hch@caldera.de)
Wed, 1 Aug 2001 23:18:55 +0200

On Wed, Aug 01, 2001 at 09:03:20PM +0000, Andries.Brouwer@cwi.nl wrote:
> Dear Linus, Alan, Al, Christoph, all,
>
> If one mounts without specifying a type, mount will try
> all available types. After having tried vxfs the next type
> will cause
> set_blocksize: b_count 1 ...
> since vxfs forgets to free a block.
> The patch below adds the missing brelse().
> (In fact there are more resources that are never freed there -
> maybe the maintainer can have a look some time -
> I only added a comment.)

Yes, I already hit that one time but forgot to fix it.
I'll update vxfs to free all resources somewhen later this week.

Thanks for the catch!

> When mount continues to try all types, it may try V7.
> That always succeeds, there is no test for magic or so,
> and after garbage has been mounted as a V7 filesystem,
> the kernel crashes or hangs or fails in other sad ways.
> Have not tried to debug.

Maybe some sanity checks should be added?

I'd like to propose:

s_nfree <= V7_NICFREE
s_ninode <= V7_NICINOD
s_time != 0

Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/