Re: Kernel diff_small_2.4.8pre2_2.4.8pre3

[Andrea Arcangeli]

On Mon, Jul 30, 2001 at 08:08:13PM +0200, Andrea Arcangeli wrote:
> diff -urN 2.4.8pre2/include/asm-i386/softirq.h 2.4.8pre3/include/asm-i386/softirq.h
> --- 2.4.8pre2/include/asm-i386/softirq.h	Sun Jul 29 06:02:41 2001
> +++ 2.4.8pre3/include/asm-i386/softirq.h	Mon Jul 30 20:07:54 2001
> @@ -28,8 +28,6 @@
>  	unsigned long flags;						\
>  									\
>  	__save_flags(flags);						\
> -	if (!(flags & (1 << 9)))					\
> -		BUG();							\
>  	barrier();							\
>  	if (!--*ptr)							\
>  		__asm__ __volatile__ (					\

if you drop the bugcheck you should drop the __save_flags and flags too.

What was the problem with it? I seen a report from Chris but that sounds
like a bug in a caller of the the smp-call function (smp-call must be
run with irq enabled as it's written explicitly in the comment on top of
it).

Andrea