Re: [PATCH] Re: 2.4.8-pre1 build error in drivers/parport/parport_pc.c

[Philip Blundell]

--==_Exmh_-666839274P
Content-Type: text/plain; charset=us-ascii

>Hmm, these functions are multiply defined, namely in the c source and
>in it's header file. I see no reason why someone should do this. The
>problem was hidden in older kernel releases by the fact that these
>functions were declared "extern __inline__" which is absolutely
>nonsense in my opinion. So the solution should be to just remove these
>inline functions from the c source file, which can be done with the
>following simple and stupid patch.
>
>This should be the correct solution, or did I miss the vital point?

I think you did miss the vital point: this will probably break with 
CONFIG_PARPORT_OTHER.

Declaring them "extern inline" in parport_pc.h is exactly the right thing to 
do.  What do you think is wrong with that?

p.

--==_Exmh_-666839274P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.5 (GNU/Linux)
Comment: Exmh version 2.1.1 10/15/1999 (debian)

iD8DBQE7Yuq6VTLPJe9CT30RAqD2AJ9Z80DI5FlP08PxtMruZ2VWYrh8UwCdHfz6
buNAlPfpnXM5CCqvEzC5EmA=
=zRDp
-----END PGP SIGNATURE-----

--==_Exmh_-666839274P--