Re: [PATCH] net/ipv4/arp.c, kernel 2.4.6 - PROXY_ARP bug on shaper device

[David S. Miller]

Roberto Arcomano writes:
 > Solution: The patch investigates about the shaper device 
 >           (it compares string with "shaper"): if yes, we 
 > 	  search the real interface attached to shaper
 > 	  (we read value of priv->dev) and we use that to
 > 	   make the classic proxy arp devices compare.
 > 
 > Problems: The patch uses routine "strncmp" which is not the
 >           best thing (I guess).

This is gross, make a device flag and have shaper set that
flag during shaper device init, then have ARP test it.

Make the name of the flag reflect what the attribute is that shaper
has (and potentially other devices could have) which makes this ARP
special case necessary.  Ie. don't name the flag NETIF_F_SHAPER :-)

Later,
David S. Miller
[e-mail]