Re: patch for allowing msdos/vfat nfs exports

Alan Cox (alan@lxorguk.ukuu.org.uk)
Tue, 24 Jul 2001 18:51:16 +0100 (BST)


> I've been using it for half a day now and so far it hasn't done
> anything bad, but please be careful if you decide to test it and
> backup your data and after testing, be sure to compare your data
> to your backup.

Rename ?

> + struct inode *inode = dentry->d_inode;
> + unsigned int i_pos = MSDOS_I(inode)->i_location;

i_location is not a constant across renames or other operations, so you may
inadvertantly do I/O to completely the wrong file

The infrastructure looks great, I just don't think your handles are safe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/