Re: Inclusion of zoned inactive/free shortage patch

[Linus Torvalds]

On Thu, 19 Jul 2001, Marcelo Tosatti wrote:
>
> Well, here is a patch on top of -ac5 (which already includes the first
> zoned based approach patch).

Looks ok.

I'd like to see what the patch looks on top of a virgin tree, as it should
now be noticeably smaller (no need to pas extra parameters etc).

> I changed inactive_plenty() to use "zone->size / 3" instead "zone->size /
> 2".
>
> Under _my_ tests using half of the perzone total pages as the inactive
> target was too high.

This is one of the reasons I'd like to see the virtgin patch - if the "/2"
is too high, then that should mean that the behaviour is basically
unchanged from before, right? Which would be a good sign that this kicks
in gently - and I agree that "/3" sounds saner (or even "/4" - but we
should double-check that the global inactive function is guaranteed to
never trigger with all zones close to the "/4" target if so).

I haven't checked what your changes to "total_free_shortage()" are in the
-ac tree, so I don't know what the effect of that would be.

		Linus