Agreed 100%.
> Why was so much of it macroised rather than turned into library routines ?
Customization is the big one. Some drivers need AGP, some need MTRRs,
some need DMA, some need interrupts etc. With the templates, this is
done with minimal code duplication, and allows the final routines to be
space-efficient -- only the code that each driver actually needs is
present. This is advantageous when building as modules, or building a
single driver into the kernel. You could argue that it's less important
when building many drivers into the kernel, but how many people do that?
Plus, there were symbol clashing problems with building some drivers
into the kernel and some as modules. Keith Owens could comment on
that. The new code avoids this problem as well.
> > ... New drivers are much
> > easier to write as well, which is a nice side-effect.
>
> That I can believe
Pity that no new drivers have been written to prove this...
-- Gareth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/