Re: (patch-2.4.6) Fix oops with Iomega Clik! (ide-floppy)

[Pete Zaitcev]

In linux-kernel, you wrote:
> [e-mail] said:
> >  Linus, please consider applying the following patch. 
> > 
> > --- linux-2.4.7-pre6/include/linux/malloc.h	Thu Jul 12 03:53:53 2001
> > +++ linux-2.4.7-pre6+mallocRIP/include/linux/malloc.h	Thu Jan  1 12:00:00 1970
> > @@ -1,5 +0,0 @@
> > -#ifndef _LINUX_MALLOC_H
> > -#define _LINUX_MALLOC_H
> > -
> > -#include <linux/slab.h>
> > -#endif /* _LINUX_MALLOC_H */
> 
> Doing that in the middle of a supposedly stable series, even if it wasn't a 
> fundamentally stupid thing to do in the first place, isn't really very 
> sensible.
> 
> --
> dwmw2

It would be much better to add something like this:

#warning "Please use slab.h instead"

The patch above should be put off until the 2.5.

-- Pete