proc_scsi_gen_write PAGE_SIZE

[Hugh Dickins]

Al,

Forgive me if I guess wrongly, but patch-2.4.5.log says of -pre3:
 - Al Viro: sanity-check user arguments, zero-terminated strings etc.
from which I assume you made the proc_scsi_gen_write() mod below.

I'm not sure what it ought to say instead, but I believe the "else"
case is wrong: buffer[length] is in that case buffer[PAGE_SIZE],
just beyond the end of the page we have allocated.

Hugh

--- v2.4.4/linux/drivers/scsi/scsi.c	Wed Apr 25 16:18:54 2001
+++ linux/drivers/scsi/scsi.c	Tue May 15 01:29:34 2001
@@ -1572,6 +1572,11 @@
 	copy_from_user(buffer, buf, length);
 
 	err = -EINVAL;
+	if (length < PAGE_SIZE)
+		buffer[length] ='\0';
+	else if (buffer[length])
+		goto out;
+
 	if (length < 11 || strncmp("scsi", buffer, 4))
 		goto out;