Re: [PATCH] ext2 cleanups

[Alexander Viro]

On Wed, 11 Jul 2001, Andreas Dilger wrote:

> This patch cleans up the ext2 code in various places.  It is mostly cosmetic
> changes to comments, avoiding lines > 80 columns, removing redundant #ifdef
> lines, etc.  It also adds the new COMPAT flags from the current e2fsprogs
> into include/linux/ext2_fs.h.
> 
> It removes the "not_used_1" field from struct ext2_inode_info, which is
> an in-memory only struct, so there is no need to keep this for "compatibility
> reasons", unlike unused fields in the on-disk data structs.
> 
> It removes the inclusion of <linux/ext2_fs.h> and <linux/minix.h> from
> ksyms.c, because these filesystems do not export any symbols, and they
> can do it themselves now anyways.

	Andreas, could you take a look at ext2 patchkit? It's on
ftp.math.psu.edu/pub/viro/ext2 and I'm going to start feeding that
stuff as soon as 2.5 opens. Patches there (the largest being ~7Kb,
most much smaller) are what I've cut into reasonable pieces; since
there's already 27 chunks in the set the rest is not too high on
my immediate list...

	BTW, folks, since minixfs patch got no complaints during the
last week... Alan, Linus - do you want it in your trees? It switches
the thing to page cache (pretty similar to sysvfs rewrite) and cleans
the things up a bit.