> > + NCR_LOCK_NCB(np, flags);
> > + del_timer(&np->timer);
> > + NCR_UNLOCK_NCB(np, flags);
>
> I'm only reading the diff, but this change looks wrong.
> The simplest solution is del_timer_sync() instead of
> LOCK;del_timer;UNLOCK.
I didn't even realize there was a del_timer_sync(). That does what is
needed. 3 lines become 1, I guess.
Thanks, CC:ed to Gerard and crew.
-- Tim Hockin Systems Software Engineer Sun Microsystems, Cobalt Server Appliances thockin@sun.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/