Re: Announcing Journaled File System (JFS) release 1.0.0 available

[Yaacov Akiba Slama]

Steve Lord wrote:

>>Hi,
>>
> 
>>So I only hope that the smart guys at SGI find a way to prepare the 
>>patches the way Linus loves because now the file 
>>"patch-2.4.5-xfs-1.0.1-core" (which contains the modifs to the kernel 
>>and not the new files) is about 174090 bytes which is a lot.
>>
>>YA
>>
>>
> 
> But that is not a patch intended for Linus, it is intended to enable all
> the XFS features. I have a couple of kernel patches which total 46298 bytes
> which get you a working XFS filesystem in the kernel, and I could do
> lots of things to make them smaller. When you hit header files in the
> correct manner for different platforms the size tends to mushroom.
> These lines are all in different fcntl.h files for example:
> 
> +#define O_INVISIBLE    01000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    0x80000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    02000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    01000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    01000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    0x200000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    01000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    0x200000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    01000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    02000000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    0x80000 /* invisible I/O, for DMAPI/XDSM */
> +#define O_INVISIBLE    02000000 /* invisible I/O, for DMAPI/XDSM */
> 
> You make the patches look a lot bigger than they really are. There is
> a difference between a patch which is placing things in the correct
> places and one which is designed to be as short as possible.
> 

Agree.
But IMHO, you need to be more "visible" and to already propose those 
kernel modifications - even not the final ones - in lkml in order to let 
everyone see them and change the current think (even by Alan) that XFS 
is too intrusive for 2.4.
There are other people involved in the files you need to change and the 
more your patches are visibles, the more they are "credibles".
I didn't want to critisize XFS (or JFS and ext3) but to give some points 
about their integration in 2.4.
YA

> Steve
> 
> 
> 
> 

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com