Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error

[Andrzej Krzysztofowicz]

Keith Owens wrote:
> On Thu, 28 Jun 2001 00:07:13 -0400, 
> Jeff Garzik <[e-mail]> wrote:
> >Steven Cole wrote:
> >> -   dep_bool '  EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI
> >> +   dep_bool '  EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI $CONFIG_PCI
> >
> >See the "EISA" and "VLB" parts in there?  EISA != PCI
> 
> Against 2.4.6-pre6.
> 
> Index: 6-pre6.1/drivers/net/Config.in
> --- 6-pre6.1/drivers/net/Config.in Thu, 28 Jun 2001 10:34:32 +1000 kaos (linux-2.4/l/c/9_Config.in 1.1.2.2.1.3.1.8 644)
> +++ 6-pre6.1(w)/drivers/net/Config.in Thu, 28 Jun 2001 16:07:03 +1000 kaos (linux-2.4/l/c/9_Config.in 1.1.2.2.1.3.1.8 644)
> @@ -142,7 +142,11 @@ if [ "$CONFIG_NET_ETHERNET" = "y" ]; the
>        tristate '  NE/2 (ne2000 MCA version) support' CONFIG_NE2_MCA
>        tristate '  IBM LAN Adapter/A support' CONFIG_IBMLANA
>     fi
> -   dep_bool '  EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI
> +   if [ "$CONFIG_ISA" = "y" -o "$CONFIG_EISA" = "y" -o "$CONFIG_PCI" = "y" ]; then

CONFIG_EISA check in this condition is redundant.
Intentionally ?

> +     bool '  EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI

Andrzej
-- 
=======================================================================
  Andrzej M. Krzysztofowicz               [e-mail]
  phone [phone]
Faculty of Applied Phys. & Math.,   Technical University of Gdansk