Re: [PATCH] swapin flush cache bug

NIIBE Yutaka (gniibe@m17n.org)
Thu, 28 Jun 2001 09:07:52 +0900 (JST)


Marcelo Tosatti wrote:
> I think Stephen C. Tweedie has some considerations about the cache
> flushing calls on do_swap_page().

Yup. IIRC, he said that flushing cache at do_swap_page() (which I've
tried at first) is not good, because it's the hot path and it causes
another performance problem in apache or sendmail, where many
processes share the pages in swap cache.

Then, the fix I sent yesterday is second try. The flush is moved to
I/O routine, instead of do_swap_page().

Actually, I really wonder why current code causes no problem in other
architectures.

-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/