Re: Ramdisk Bug?

[Andrea Arcangeli]

On Wed, Jun 27, 2001 at 10:18:26PM +0800, Zeng Yu wrote:
> Hi all,
> 
> I think find a ramdisk bug of 2.4.4 kernel -- ramdisk
> use both buffers and cached mem of the same size, thus
> double the mem use. 
> mke2fs -m0 /dev/ram1
> mount /dev/ram1 /mnt
> dd if=/dev/zero of=/mnt/data bs=1k count=110000
> cat /proc/meminfo will see that both buffers and
> cached mem increase about 110M of size. More worse,
> the cached mem won't be released untile the ramdisk
> be umounted. I attach the meminfo and slabinfo before

the "more worse" part is the only thing which is wrong. The fact cache
also grows to 110M is expected and it won't change. With the
blkdev-pagecache patch the cache will grow to 220M and it will shrink to
110M if you are low on memory (buffer cache will only be allocated for
the superblock and inode metadata with ext2).

use ramfs if you want zero ram duplication and you don't care about the
physical representation on disk of your data in cache.

> and after data transfer below.

Try this patch to fix the "more worst part"  (beware totally untested).

--- blkdev-rd/include/linux/swap.h.~1~	Sun Jun 24 02:06:13 2001
+++ blkdev-rd/include/linux/swap.h	Wed Jun 27 16:47:57 2001
@@ -274,7 +274,7 @@
 #endif
 
 #define page_ramdisk(page) \
-	(page->buffers && (MAJOR(page->buffers->b_dev) == RAMDISK_MAJOR))
+	(!page->mapping && page->buffers && (MAJOR(page->buffers->b_dev) == RAMDISK_MAJOR))
 
 extern spinlock_t swaplock;
 

Andrea