Re: [PATCH] skb destructor enhancement idea

[David S. Miller]

Will writes:
 > > Add an ifdef and the knobs you need to the skb struct directly just
 > > like netfilter does.
 > 
 > So I should #ifdef throughout the tcp and socket code wherever skb's 'destructor' is
 > called to call mine as well? And multiply that by N driver writers who'd like to do
 > the same thing? Sounds messy...

Besides low-level packet frobbing, I can't think of any other
application.

In fact, more appropriate would be to extend netfilter to handle
low-level things as well as med/upper level things.

Then we wouldn't need driver specific things, this is my whole
point.  You're designing for yourself and nobody else.  When
people want to add things to sk_buff it usually is for a
not so well thought reason.

Later,
David S. Miller
[e-mail]